Fix panning of zoomed images #1863
Conversation
| @@ -240,7 +240,7 @@ export default { | |||
| const growY = this.zoomHeight - this.height | |||
|
|
|||
| this.shiftX = Math.min(Math.max(moveX, -growX / 2), growX / 2) | |||
| this.shiftY = Math.min(Math.max(moveY, -growY / 2), growX / 2) | |||
There was a problem hiding this comment.
wow, that looks like a nice typo! Can't believe that hasn't been caught in all those years
There was a problem hiding this comment.
The key issue was incorrect calculation of top/left margins. I must admit that I am not fluent enough in CSS to fully understand why the shift must be multiplied by 2 to get the margins correct. But observations of the calculated box model in dev tools and testing confirmed this is the case. 😇
|
/backport to stable27 |
|
/backport to stable26 |
backportbot-nextcloud
bot
added
the
backport-request
skjnldsv
added
4. to release
Signed-off-by: Dariusz Olszewski <[email protected]>
skjnldsv
force-pushed
the
fix/pan-zoomed-images
branch
from
7b3c13b to
a33d766
Compare
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
/backport to stable27 |
|
/backport to stable26 |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
Hello there, We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
When an image is enlarged (zoomed using the scroll wheel), panning (dragging) behaves incorrectly:
I see that there is an open PR #1063 that is broader in scope and apparently fixes this issue as well. However it did not progress for over a year now. 😞
In this PR, I propose a very small, alternative change that should fix just the two issues mentioned above.
If you think it is better to continue with #1063, I can try to pick it up instead.
Full image:
Before
Zoomed image dragged down as much as possible - row 0 is not visible
After
Zoomed image dragged down as much as possible - row 0 is visible